[dancer-users] return_url => request->path [Dancer::Plugin::Auth::Extensible]

[David Precious]

On Mon, 3 Jun 2013 23:00:15 +0200 (CEST)
Henk van Oers <hvo.pm at xs4all.nl> wrote:
> Users of DPAE,
> 
> ---- %<----
> $ grep request Extensible.pm
> return redirect uri_for($loginpage, { return_url => request->path });
[...]


> I do not want the SCRIPT_NAME
> but I do want the query_string "?foo=bar"
> in the return_url.
> 
> Changing "request->path" into "request->request_uri"
> does it for me.
> 
> Is this the "right" patch?

That sounds sane to me - request->request_uri is far more likely to be
what the user will want than request->path.

Good spot :)

Feel free to submit a PR for that change if you have a moment?



-- 
David Precious ("bigpresh") <davidp at preshweb.co.uk>
http://www.preshweb.co.uk/     www.preshweb.co.uk/twitter
www.preshweb.co.uk/linkedin    www.preshweb.co.uk/facebook
www.preshweb.co.uk/cpan        www.preshweb.co.uk/github